Add more clippy lints #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
May 24, 2023
Comment on lines
+10
to
+11
| clippy::expect_used, | ||
| clippy::unwrap_used |
There was a problem hiding this comment.
I'm generally not a fan of these two.
Unwrap and Expect are pretty explicit so there is not much risk that they are used badly, and they can be more readable than abusing the type system...
And they still leave many places for panics (syscall! can very easily panic, but so can try_syscall! if the inputs are too large).
There was a problem hiding this comment.
- I admit I do not see entirely your point. Depends on your target, but I rather like to avoid crashing completely, and thus avoid unwraps where possible. I understand, that instead you would rather panic on any unexpected state instead, than keep the device working, but I am not convinced this is better.
- I plan to move
syscallstotry_syscallstoo, if that is useful in any way (I have 13 of them, out of 52 total). - I wish
try_syscallpanicking would be fixed. Is this not a bug in the framework?
There was a problem hiding this comment.
- https://blog.burntsushi.net/unwrap/
- In opcard I use
syscallwhen I know it can't fail - https://docs.rs/trussed/latest/src/trussed/client.rs.html#747-758 if the client can't create the value and put it in the interchange,
try_syscallwill panic.
I do think it should instead generate an error integrated with the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more clippy rules, and fix reported issues.
Fixes #39