Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core info
Severity & impact on go-git
No impact. As per a comment on Viper, the affected package is not compiled into the final library. Cobra uses Viper which uses Crypt which uses a etcd client. The etcd package imports
github.com/dgrijalva/jwt-go
but theclient
package used by crypt doesn't use it.Explanation
This CVE is in a nested deps:
github.com/dgrijalva/jwt-go
.Affected direct dependencies:
Possible fixes:
cobra
once they updatedviper
, once they updatedcrypt
, once they updatedetcd
, once they updatedjwt-go
(best, but might not happen before a long time due how deep the CVE is)Research
CVE in:
github.com/dgrijalva/jwt-go
< 4.0.0-preview1Affected dependencies:
After looking at Viper's source code, Viper doesn't use
jwt-go
directly.Viper
usescrypt
which usesetcd
which usesjwt-go
. Theetcd
package used by Crypt isetcd/client
, which doesn't importsjwt-go
Nancy report