Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install command in documentation compatible with fish shell #422

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

doubledup
Copy link
Contributor

@doubledup doubledup commented Dec 17, 2022

With the fish shell support added earlier this year, Nix supports installations in fish shell out of the box. The installation instructions still use process substitution syntax that's specific to other shells (eg. bash & zsh), so users installing Nix from fish shell must translate the command before the installation will work.

This PR makes the install commands in the installation instructions compatible with fish shell.

Running the current install command in fish produces

$ sh <(curl -L https://nixos.org/nix/install)
...
fish: Invalid redirection target: 
sh <(curl -L https://nixos.org/nix/install)
   ^

Running the command with the correct fish syntax starts the installer (also tested with the --daemon flag passed to the installer)

$ curl -L https://nixos.org/nix/install | sh
...
Switching to the Multi-user Installer
Welcome to the Multi-User Nix Installation
...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@doubledup
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@fricklerhandwerk
Copy link
Collaborator

As commented on your other PR we could just as well use

curl -L https://nixos.org/nix/install | sh

@doubledup
Copy link
Contributor Author

@fricklerhandwerk That's much better, thanks! I've updated the PR and the description.

@doubledup doubledup changed the title Add fish shell install command to documentation Make install command in documentation compatible with fish shell Jan 8, 2023
@domenkozar domenkozar merged commit ea42f78 into NixOS:master Jan 24, 2023
@doubledup doubledup deleted the patch-1 branch January 26, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants