Improve command not found errors #2498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Oct 30, 2018
src/libexpr/primops/fetchGit.cc
Outdated
| std::ostringstream out; | ||
| out << e.what() << std::endl; | ||
| out << "The program 'git' is currently not installed. It is required by builtins.fetchGit" << std::endl; | ||
| out << "You can install it by typing one of the following:" << std::endl; |
There was a problem hiding this comment.
Suggested change
| out << "You can install it by typing one of the following:" << std::endl; | |
| out << "You can install it by running the following:" << std::endl; |
grahamc
reviewed
Oct 30, 2018
| std::ostringstream out; | ||
| out << e.what() << std::endl; | ||
| out << "The program 'hg' is currently not installed. It is required by builtins.fetchMercurial" << std::endl; | ||
| out << "You can install it by typing one of the following:" << std::endl; |
There was a problem hiding this comment.
Suggested change
| out << "You can install it by typing one of the following:" << std::endl; | |
| out << "You can install it by running the following:" << std::endl; |
|
This is awesome! |
LnL7
force-pushed
the
improve-command-not-found-errors
branch
from
218ef8b to
4980230
Compare
edolstra
reviewed
Oct 30, 2018
src/libexpr/primops/fetchGit.cc
Outdated
| if (state.allowedPaths) | ||
| state.allowedPaths->insert(gitInfo.storePath); | ||
| } catch (ExecError & e) { | ||
| if (e.status / 256 == 127) { |
There was a problem hiding this comment.
Should be WEXITSTATUS(e.status) == 127.
There was a problem hiding this comment.
Thanks, didn't realise where to look for that.
edolstra
reviewed
Oct 30, 2018
src/libexpr/primops/fetchGit.cc
Outdated
| out << "The program 'git' is currently not installed. It is required for builtins.fetchGit" << std::endl; | ||
| out << "You can install it by running the following:" << std::endl; | ||
| out << "nix-env -f '<nixpkgs>' -iA git"; | ||
| throw ExecError(e.status, out.str()); |
There was a problem hiding this comment.
This should use format strings:
throw ExecError("%s\nThe program 'git' is currently not installed. ...", e.what());
|
ping |
Bash uses the same exit code to indictate a binary was not found in PATH.
LnL7
force-pushed
the
improve-command-not-found-errors
branch
from
a79f726 to
b022d8e
Compare
LnL7
force-pushed
the
improve-command-not-found-errors
branch
from
b022d8e to
75c6c42
Compare
|
Just built the rebased version, and checked out the code at https://github.com/NixOS/nix/pull/2498/files?w=1 Looks good to me I think |
edolstra
reviewed
Jul 2, 2019
src/libexpr/primops/fetchGit.cc
Outdated
|
|
||
| if (state.allowedPaths) | ||
| state.allowedPaths->insert(state.store->toRealPath(gitInfo.storePath)); | ||
| } catch (ExecError & e) { |
There was a problem hiding this comment.
It's better to put this check in exportGit because (on the flakes branch) it's used in other places as well.
There was a problem hiding this comment.
Sure, should I do the same for mercurial?
|
Sure, should I do the same for mercurial?
Yeah, probably should :)
|
LnL7
force-pushed
the
improve-command-not-found-errors
branch
from
419e211 to
cfe3cbb
Compare
|
Still relevant but needs a rebase. Current output with flakes is: |
|
I'm happy to rebase this, but it's been open for quite some time without getting attention. |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error message when git/mercurial are not available. eg.