Use exit instead of return in /etc/profile.d/nix-daemon.fish #7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of Fish (such as those bundled with Ubuntu LTS 22.04) do not support return outside of functions. We need to use the equivalent exit instead.
Minion3665
pushed a commit
to Minion3665/nix
that referenced
this pull request
Feb 23, 2023
Use exit instead of return in /etc/profile.d/nix-daemon.fish
peromage
added a commit
to peromage/pix
that referenced
this pull request
Apr 27, 2023
peromage
added a commit
to peromage/rice-legacy
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of Fish (anything before 3.4) do not support using
returnoutside of functions. While Fish 3.3 is a year old, it is the version packaged by Ubuntu LTS 22.04, so still sees significant usage.Using the equivalent
exitinstead ofreturnshould add compatibility with older versions.