python3Packages.bootstrapped-build: to replace pip #105714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
commented
Dec 2, 2020
| substitutions = { | ||
| inherit pythonInterpreter pythonSitePackages; | ||
| }; | ||
| } ./build-build-hook.sh) {}; |
FRidh
commented
Dec 2, 2020
| runHook preInstall | ||
|
|
||
| export PYTHONPATH="$(ls | tr '\n' '\:'):''${PYTHONPATH:-}" | ||
| for pkg in $(find . -mindepth 1 -maxdepth 1 -type d -exec basename {} \;); do |
There was a problem hiding this comment.
for every runtime dep of build we create a wheel and install it. This requires the build backends to be available already. We probably end up needing to add setuptools and flit here as well.
ofborg
bot
added
8.has: package (new)
| @@ -46,6 +46,15 @@ in rec { | |||
| }; | |||
| } ./flit-build-hook.sh) {}; | |||
|
|
|||
| buildBuildHook = callPackage ({ build, wheel }: | |||
There was a problem hiding this comment.
That name is not that nice.
2 tasks
SuperSandro2000
added
the
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
FRidh
force-pushed
the
bootstrapped-build
branch
from
6dfd0ca to
9c245d9
Compare
stale
bot
removed
the
2.status: stale
|
Managed to get bootstrapping going with |
ofborg
bot
removed
the
2.status: merge conflict
Comment on lines
59
to
62
| export PYTHONPATH="$(pwd)/installer/src:$(pwd)/wheel/src:$(pwd)/build/src:$(pwd)/setuptools/pkg_resources:$PYTHONPATH" | ||
|
|
||
| ''; |
There was a problem hiding this comment.
Suggested change
| export PYTHONPATH="$(pwd)/installer/src:$(pwd)/wheel/src:$(pwd)/build/src:$(pwd)/setuptools/pkg_resources:$PYTHONPATH" | |
| ''; | |
| export PYTHONPATH="$(pwd)/installer/src:$(pwd)/wheel/src:$(pwd)/build/src:$(pwd)/setuptools/pkg_resources:$PYTHONPATH" | |
| ''; |
|
|
||
| postFixup = '' | ||
| wrapPythonPrograms | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| ''; | |
| ''; | |
| meta = { | |
| description = "Package for bootstrapping the Python packages set."; | |
| maintainers = [ lib.maintainers.fridh ]; | |
| }; |
| # json = builtins.toFile "instructions.json" (builtins.toJSON data); | ||
| srcs = with lib; catAttrs "src" runtimeDeps; | ||
| in stdenv.mkDerivation rec { | ||
| name = "${python.libPrefix}-bootstrapped-build-installer"; |
There was a problem hiding this comment.
I think it would be nice if we had some version attribute but honestly I have no idea what we should use because this is just a collection of files.
| installer | ||
| ]; | ||
| # runtimeDeps = lib.remove python (requiredPythonModules [ build installer setuptools wheel ]); | ||
| data = map (drv: lib.getAttrs ["pname" "src" ] drv) runtimeDeps; |
There was a problem hiding this comment.
Suggested change
| data = map (drv: lib.getAttrs ["pname" "src" ] drv) runtimeDeps; | |
| data = map (drv: lib.getAttrs [ "pname" "src" ] drv) runtimeDeps; |
Comment on lines
+83
to
+86
| if [[ -d $pkg ]]; then | ||
| echo "Building $pkg wheel" | ||
| ${python.pythonForBuild.interpreter} -m build --wheel "$pkg" --no-isolation --skip-dependency-check | ||
| fi |
There was a problem hiding this comment.
Normally shell inside of nix files is intended with 2 spaces.
FRidh
commented
Jan 17, 2022
| strictDeps = true; | ||
|
|
||
| nativeBuildInputs = [ | ||
| unzip |
ofborg
bot
added
the
2.status: merge conflict
stale
bot
added
the
2.status: stale
FRidh
force-pushed
the
bootstrapped-build
branch
from
1a47d88 to
f77e33a
Compare
stale
bot
removed
the
2.status: stale
ofborg
bot
removed
the
2.status: merge conflict
ofborg
bot
requested review from
fabaff,
mweinelt,
cpcloud,
kamadorueda,
SuperSandro2000 and
jonringer
1 task
12 tasks
|
Superseded by #245509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildis a lightweight PEP 517 frontend for building wheels that couldreplace pip for this purpose.
installeris a new project for installing wheels.Why replace
pipwithbuildandinstaller?piphas a largecodebase doing many more things, and it vendors its dependencies.
See also https://github.com/FFY00/python-bootstrap
Might become significantly simpler if pypa/flit#511 is merged.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)TODO
bootstrapped-buildbootstrapped-build-installerpipInstallFlags = [ "--ignore-installed" ];for eachbootstrapped-builddep