pythonPackages.greenlet: 0.4.17 -> 1.0.0 #118627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Update greenlet to 1.0.0.
meinheld declares a dependency to greenlet <0.5, but according to [1]
and [2], there are no API or ABI changes leading to greenlet-1.0.0, so
it seems reasonable to drop the strict requirement. This commit
uses substituteInPlace to patch setup.py since no upstream commit has
landed in the main branch yet.
Morehover, quoting [2]:
Prior to greenlet 1.0 there were no semantic meanings attached to
greenlet versions — API and ABI regularly changed from 0.4.x
to 0.4.x+1, so their current pin doesn't make much sense anyway.
nix-review reveals few broken packages that are also broken in master.
[1] mopemope/meinheld#123
[2] benoitc/gunicorn#2541 (comment)
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages marked as broken and skipped:
7 packages failed to build and already failed to build on hydra master:
124 packages built:
|
SuperSandro2000
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update greenlet to 1.0.0.
meinheld declares a dependency to greenlet <0.5, but according to [1]
and [2], there are no API or ABI changes leading to greenlet-1.0.0, so
it seems reasonable to drop the strict requirement. This commit
includes the patch in nixpkgs since no upstream commit has landed in the
main branch yet.
Morehover, quoting [2]:
nix-review reveals few broken packages that are also broken in master.
[1] mopemope/meinheld#123
[2] benoitc/gunicorn#2541 (comment)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)