Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/slurm: 20.11.5.1 -> 20.11.6.1, improve security #121336

Merged
merged 2 commits into from
May 4, 2021
Merged

nixos/slurm: 20.11.5.1 -> 20.11.6.1, improve security #121336

merged 2 commits into from
May 4, 2021

Conversation

markuskowa
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 30, 2021
@ofborg ofborg bot requested a review from jagajaga April 30, 2021 22:29
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 30, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121336 at d07185f9 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python38Packages.pyslurm
  • python39Packages.pyslurm
2 packages built successfully:
  • slurm
  • slurm-spank-x11

@markuskowa markuskowa merged commit 741ed21 into NixOS:master May 4, 2021
@markuskowa markuskowa deleted the upd-slurm branch May 4, 2021 09:00
@Stunkymonkey Stunkymonkey mentioned this pull request Feb 4, 2024
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuskowa @r-rmcgibbo