Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata fetchers: use umask instead of fetch-and-chmod #121449

Merged
merged 1 commit into from
May 4, 2021
Merged

metadata fetchers: use umask instead of fetch-and-chmod #121449

merged 1 commit into from
May 4, 2021

Conversation

endgame
Copy link
Contributor

@endgame endgame commented May 1, 2021

Motivation for this change

#121293 - chmod leaves opportunity to leak secrets

Things done
  • Tested that busybox sh supports a umask command
  • Built a NixOS AMI on EC2 against this branch, booted it, and verified that it downloaded metadata with correct permissions.

cc @grahamc , who was also pinged for this change.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 1, 2021
@endgame endgame mentioned this pull request May 1, 2021
Open
42 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 1, 2021
@infinisil infinisil merged commit 37e2fbd into NixOS:master May 4, 2021
@endgame endgame deleted the metadata-fetcher-umask branch May 4, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endgame @infinisil