Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: Add aarch64-darwin support #170715

Merged
merged 1 commit into from
May 2, 2022

Conversation

sloane-shark
Copy link
Contributor

Description of changes

Add support for aarch64-darwin packages for vscodium, now that they have addressed VSCodium/vscodium#597

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Apr 28, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 28, 2022
@takeda
Copy link
Contributor

takeda commented Apr 28, 2022

nixpkgs-review said there's nothing to build.

Manually fetching and building appears to produce exact same output as without this patch on x86_64-linux. The binary appears to work (called with --help and --version). Looks good to me.

@turion
Copy link
Contributor

turion commented Apr 28, 2022

LGTM trusting that you've successfully built it on aarch64-darwin :)

@sloane-shark
Copy link
Contributor Author

Can confirm I built and tested the binaries on my M1 Macbook Pro :)

@turion turion merged commit 85651a7 into NixOS:master May 2, 2022
@turion
Copy link
Contributor

turion commented May 2, 2022

Thanks!

@bobby285271 bobby285271 added the 8.has: port to stable A PR already has a backport to the stable release. label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants