Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: 1.25.2 -> 1.26.0 #179824

Merged
merged 1 commit into from
Jul 1, 2022
Merged

minikube: 1.25.2 -> 1.26.0 #179824

merged 1 commit into from
Jul 1, 2022

Conversation

alias-dev
Copy link
Contributor

Description of changes

Updates minikube to 1.26.0 (see release notes).

There is a known issue with use of the cri-o runtime in rootless mode in this release, but this can be worked around with containerd (see kubernetes/minikube#14400 (comment)) - is this acceptable or should the update be held off until the cri-o issue is resolved?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit bbb6239 into NixOS:master Jul 1, 2022
@alias-dev alias-dev deleted the fix/minikube-update branch July 1, 2022 21:19
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants