Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.myst-parser: relax docutils constraint #185103

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 4, 2022

Two failing tests that expect some autogenerated URLs to use http, while
the use https. Also an old path to python peps was replaced with a new
path.

Cherry-picked from ad6dd34.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Aug 4, 2022

Similar fix, that does not require carrying a patch. NixOS/nixpkgs@ad6dd34 (#185037)

@flokli
Copy link
Contributor Author

flokli commented Aug 4, 2022

Makes sense. Should I cherry-pick this into here instead, or do you expect #185037 to be ready to merge soon?

@mweinelt
Copy link
Member

mweinelt commented Aug 4, 2022

Feel free to pick it, if you want it now.

Two failing tests that expect some autogenerated URLs to use http, while
the use https. Also an old path to python peps was replaced with a new
path.
@flokli flokli force-pushed the myst-parser-fix-docutils-0.19 branch from 210d4a7 to a1bd4e3 Compare August 4, 2022 09:24
@flokli flokli changed the title python.pkgs.myst-parser: fix build python3Packages.myst-parser: relax docutils constraint Aug 4, 2022
@mweinelt mweinelt merged commit fca8bc8 into NixOS:master Aug 4, 2022
@flokli flokli deleted the myst-parser-fix-docutils-0.19 branch August 5, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants