puddletag: remove chromaprint

[Maxwell-lt]

Chromaprint depends on m2r, which depends on mistune <2.0.0, but only mistune >2.0.0 is available.

Description of changes

Puddletag currently refuses to build due to m2r being marked broken. This is a transitive dependency through the python module chromaprint, which appears to only be a soft dependency of Puddletag. To get Puddletag building again, the easiest option is to remove the build input and patch requirements.txt.

I've successfully run Puddletag with nix run .#puddletag in my clone of nixpkgs, though I'm not sure what features even use the removed dependency, so did not test that.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[dschrempf]

Hi!

In principle, the PR is good. However, according to the puddletags README, chromaprint is a recommended dependency. Did you briefly check why m2r is broken? Can we probably fix that instead? If not, go ahead!

[peterhoeg]

The mistune/m2r issue is affecting a lot of projects. Not likely to have an easy fix.

[peterhoeg]

But will the sed invocation not break requirements.txt? I'd say do this instead:

sed -i -e '/chromaprint/d' requirements.txt

[peterhoeg]

Forget what I said - we're copying over the .in file before. I think I wrote that.........

[dschrempf]

The mistune/m2r issue is affecting a lot of projects. Not likely to have an easy fix.

I see.

In this case, this only fixes the tip of the iceberg. We need to mark chromaprint broken, and I guess mistune (but I am not informed)? Just for reference, are we talking about miyakogi/m2r#66?

[peterhoeg]

That issue is part of it. It's basically a lot of changes in mistune v2 that has broken many downstream consumers. We used to carry the old version in tandem with v2, but it was dropped as it's insecure. There are a few competing forks but no proper path forward. m2ris already flagged as broken in its current version with mistune >= 2.0 so chromaprint is transitively broken. Don't see a reason to tag it explicitly.