Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synth: apply patch to fix on rust 1.65 #201442

Merged
merged 1 commit into from
Nov 16, 2022
Merged

synth: apply patch to fix on rust 1.65 #201442

merged 1 commit into from
Nov 16, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Nov 16, 2022

Description of changes

This addresses shuttle-hq/synth#337 by pulling in shuttle-hq/synth#391 to fix the build on Rust 1.65 now that #199664 is merged.

This must be go on staging right now because Rust 1.65 is on staging, and this patch does not build using Rust 1.64.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@figsoda figsoda merged commit 189cfcd into NixOS:staging Nov 16, 2022
@tjni tjni deleted the synth-rust-1.65 branch November 16, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants