Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighthouse: 3.2.1 -> 3.3.0 #204855

Merged
merged 1 commit into from
Dec 8, 2022
Merged

lighthouse: 3.2.1 -> 3.3.0 #204855

merged 1 commit into from
Dec 8, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Dec 6, 2022

Description of changes

https://github.com/sigp/lighthouse/releases/tag/v3.3.0

This broke when Rust upgraded in #199664 and was tracked upstream in sigp/lighthouse#3695. It's been fixed and released in v3.3.0.

I do not know how to test this (other than that it builds on my aarch64-darwin machine), so I'm counting on tests and on any maintainers to help. Thank you, and sorry for any inconvenience.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni marked this pull request as draft December 7, 2022 07:11
@ofborg ofborg bot requested a review from centromere December 7, 2022 07:26
@tjni
Copy link
Contributor Author

tjni commented Dec 7, 2022

I had to mark this PR a draft until I can fix it on x86_64-darwin.

@tjni tjni marked this pull request as ready for review December 7, 2022 10:45
@tjni
Copy link
Contributor Author

tjni commented Dec 7, 2022

We need to include CoreFoundation on x86_64-darwin, while for some reason it doesn't seem needed on aarch64-darwin. We also need to use Apple SDK 11 because the package now uses kCFURLVolumeAvailableCapacityForImportantUsageKey.

@tjni
Copy link
Contributor Author

tjni commented Dec 7, 2022

The build times out when running tests on Darwin because the build itself is very slow, but timing out is as good a signal as we can get from CI since it means it passed the point where it was breaking before.

@figsoda figsoda merged commit 897e895 into NixOS:master Dec 8, 2022
@tjni tjni deleted the lighthouse branch December 8, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants