Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lief, python3Packages.lief: 0.12.3 -> 0.13.2 #251414

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

GenericNerdyUsername
Copy link
Contributor

Description of changes

Fix build and update for lief.

Closes #249419.

@Lassulus

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Lassulus August 25, 2023 18:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 25, 2023
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 251414 run on x86_64-linux 1

3 packages built:
  • lief
  • lief.py (python310Packages.lief ,python310Packages.lief.py)
  • python311Packages.lief (python311Packages.lief.py)

@Lassulus Lassulus merged commit 237ea98 into NixOS:master Aug 25, 2023
4 of 5 checks passed
@fzakaria
Copy link
Contributor

@GenericNerdyUsername this doesn't set the GIT_COMMIT_HASH in the version you get something like:

>>> import lief;print(lief.__version__)
0.13.2-

I'm not sure how to set this variable: https://github.com/lief-project/LIEF/blob/3414ded8cdcbd9705f7871c66c212b15cd74ea69/cmake/LIEFGit.cmake#L10

But that's where it is set.

@fzakaria
Copy link
Contributor

I had to do this in the meantime: fzakaria/sqlelf#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: lief
4 participants