Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: 1.19.0 -> 1.30.1 #257553

Merged
merged 1 commit into from
Jan 25, 2024
Merged

router: 1.19.0 -> 1.30.1 #257553

merged 1 commit into from
Jan 25, 2024

Conversation

KGB33
Copy link
Contributor

@KGB33 KGB33 commented Sep 27, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

router v1.19.0 fails to build on Rust 1.72^ (unstable is on 1.72.0).
See apollographql/router#3684
@bjornfor
Copy link
Contributor

Updated librusty_v8 (0.60.1 -> 0.74.3) to match the version in router's Cargo.lock.

This would be good to have in the commit message as well.

@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 257553 run on x86_64-linux 1

1 package built:
  • router

@KGB33
Copy link
Contributor Author

KGB33 commented Sep 27, 2023

Updated librusty_v8 (0.60.1 -> 0.74.3) to match the version in router's Cargo.lock.

This would be good to have in the commit message as well.

I think excluding the librusty update from the commit message is much more clear. Its a transitive dependency of router - not a standalone package.

@bjornfor
Copy link
Contributor

I think excluding the librusty update from the commit message is much more clear. Its a transitive dependency of router - not a standalone package.

That is not clear to an outsider (me). Reading the patch/commit the librusty change looked unrelated to me.

@bbigras
Copy link
Contributor

bbigras commented Nov 8, 2023

Is cmake really needed? It seems to build without it on my side. My bad. It is needed.

Any progress on this PR?

Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, thanks!

@bbigras bbigras merged commit d3a15f0 into NixOS:master Jan 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants