python3Packages.caldav: remove outdated substitutes, test with xandikos #274603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-caldav/caldav@1abfac5 python-caldav/caldav@63603d9 This is also safe to do since it does not test xandikos or radicale by default if they are not available https://github.com/python-caldav/caldav/blob/f7e00211d6230c4c2ec84645ebce6f1140394fb7/tests/conf.py#L49
10 tasks
|
Also of interest might be #243229 (review) which I also caught while looking at the |
|
Result of 1 package marked as broken and skipped:
7 packages built:
|
NickCao
approved these changes
Dec 16, 2023
dotlambda
reviewed
Dec 16, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The old patchPhase would do weird things with the setup.py, like leaving an
append("==0.2.8"), and radicale is no longer included by default anyways.python-caldav/caldav@1abfac5
python-caldav/caldav@63603d9
This is also extra safe to do since it does not test xandikos or radicale by default
if they are not available
https://github.com/python-caldav/caldav/blob/f7e00211d6230c4c2ec84645ebce6f1140394fb7/tests/conf.py#L49
Additionally I've added xandikos so it does actually test it, and have verified that more tests are being ran after adding xandikos to its
nativeCheckInputsThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.