flet: fix out of the box experience #279936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
ofborg
bot
added
11.by: package-maintainer
ofborg
bot
requested review from
hacker1024,
babariviere,
ericdallo and
FlafyDev
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
lucasew
changed the title
|
Result of 4 packages failed to build:
6 packages built:
|
|
Result of 2 packages failed to build:
8 packages built:
|
|
Result of 10 packages built:
|
1 similar comment
|
Result of 10 packages built:
|
|
How can I fix this ofborg issue? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3288 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/generic-error-with-ofborg/38498/1 |
I wasn't able to spot the issue. Maybe people experienced with Flutter like @hacker1024 can help? |
|
Result of 4 packages failed to build:
11 packages built:
|
wegank
reviewed
Mar 13, 2024
pkgs/development/compilers/dart/package-source-builders/media_kit_libs_linux/default.nix
Outdated
Show resolved
Hide resolved
|
Result of 15 packages built:
|
lucasew
force-pushed
the
flet-oob
branch
2 times, most recently
from
836b938
to
16d9ea9
Compare
|
Result of 15 packages built:
|
wegank
approved these changes
Mar 19, 2024
Signed-off-by: lucasew <[email protected]>
…s a monorepo Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
|
@ofborg build python311Packages.flet |
|
@wegank why is your name on the commits? What did you change? |
ofborg
bot
added
2.status: merge conflict
|
I rebased this PR on staging-next because there are conflicts due to the mass Python update. My name isn't on the commits (check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Right now flet just tries to download the runtime bundle and fails, the objective of this PR is to fix that.
Basically I created this because flet changed a lot since I last tried in #251877
The plan here is to use their monorepo instead of the pypi packages, use a update script on flet-flutter-client and it should propagate to the python libraries so the core and the utilites (from the same repo) would always be synced.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.