Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-show-asm: 0.2.25 -> 0.2.28 #281810

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for cargo-show-asm is: Cargo subcommand showing the assembly, LLVM-IR and MIR generated for Rust code

meta.homepage for cargo-show-asm is: https://github.com/pacak/cargo-show-asm

meta.changelog for cargo-show-asm is: https://github.com/pacak/cargo-show-asm/blob/0.2.28/Changelog.md

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 0.2.28 with grep in /nix/store/zsfqlkk6k88d4bdyn4ibd1bbp5riyvb2-cargo-show-asm-0.2.28
  • found 0.2.28 in filename of file in /nix/store/zsfqlkk6k88d4bdyn4ibd1bbp5riyvb2-cargo-show-asm-0.2.28

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-show-asm
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/zsfqlkk6k88d4bdyn4ibd1bbp5riyvb2-cargo-show-asm-0.2.28 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cargo-show-asm https://github.com/r-ryantm/nixpkgs/archive/dc9beec8aa45b6653dd38efe7b4d4d41283fe89c.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/dc9beec8aa45b6653dd38efe7b4d4d41283fe89c#cargo-show-asm

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/zsfqlkk6k88d4bdyn4ibd1bbp5riyvb2-cargo-show-asm-0.2.28
ls -la /nix/store/zsfqlkk6k88d4bdyn4ibd1bbp5riyvb2-cargo-show-asm-0.2.28/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • cargo-show-asm

Maintainer pings

cc @figsoda @oxalica @matthiasbeyer for testing.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 18, 2024
@ghost
Copy link

ghost commented Jan 19, 2024

passthru test is failing on x64 linux and darwin

@natsukium natsukium merged commit d581a6c into NixOS:master Jan 20, 2024
30 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@natsukium
Copy link
Member

Oops, sorry, I merged it by mistake.😢

@natsukium
Copy link
Member

This is the log of the passthru.tests run on the master before the merge.
This bump does not seem to be related to the above failure.

❯ nom-build -A cargo-show-asm.tests
this derivation will be built:
  /nix/store/gs6bvbravfirq8zcidsvdjwa94f928hc-test-basic.drv
this path will be fetched (0.99 MiB download, 4.21 MiB unpacked):
  /nix/store/v861fs9426lijbyvc0glphakw15ibw2j-cargo-show-asm-0.2.25
copying path '/nix/store/v861fs9426lijbyvc0glphakw15ibw2j-cargo-show-asm-0.2.25' from 'https://cache.nixos.org'
test-basic> building '/nix/store/gs6bvbravfirq8zcidsvdjwa94f928hc-test-basic.drv'
test-basic>    Compiling add v0.0.0 (/build)
test-basic>     Finished release [optimized] target(s) in 0.12s
test-basic> 
test-basic> Can't find any items matching "add::add"
error: builder for '/nix/store/gs6bvbravfirq8zcidsvdjwa94f928hc-test-basic.drv' failed with exit code 1;
       last 4 log lines:
       >    Compiling add v0.0.0 (/build)
       >     Finished release [optimized] target(s) in 0.12s
       >
       > Can't find any items matching "add::add"
       For full logs, run 'nix log /nix/store/gs6bvbravfirq8zcidsvdjwa94f928hc-test-basic.drv'.

@r-ryantm r-ryantm deleted the auto-update/cargo-show-asm branch January 20, 2024 01:07
@pacak
Copy link
Contributor

pacak commented Jan 20, 2024

Test failure is caused by the same reason as this one: pacak/cargo-show-asm#231 - rustc automatically marks add as inline and doesn't include it in the output. Marking it as #[inline(never)] should fix the problem.

@pacak
Copy link
Contributor

pacak commented Jan 20, 2024

^ this should fix the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants