nixos/wordpress: prefer 'umask' over 'chmod' #290018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
42 tasks
Stunkymonkey
force-pushed
the
wordpress-use-umask
branch
from
46de252 to
e8a12fa
Compare
Stunkymonkey
force-pushed
the
wordpress-use-umask
branch
from
e8a12fa to
67a1829
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
Drafting until this is actually tested. |
|
@Atemu |
|
ping @Atemu ? how should it test this? the test builds fine. |
|
Well, run a reasonably complex wordpress site and see if it works and that files get created with the correct permissions. The problem with this PR is that you claim to have never actually tested this other than running the smoke test. No committer will feel comfortable merging that. |
Stunkymonkey
force-pushed
the
wordpress-use-umask
branch
from
67a1829 to
0e4d7c3
Compare
|
Have you verified that this has the desired effect in a real deployment of wordpress? |
|
i have verified this with the nixos-tests. I do not have a real deployment. Feel free to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #121293
sadly I do not have a live page, so please test it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.