Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/vagrant-guest: prefer 'install' over 'chmod' #302909

Merged
merged 1 commit into from
Jun 24, 2024
Merged

nixos/vagrant-guest: prefer 'install' over 'chmod' #302909

merged 1 commit into from
Jun 24, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Apr 9, 2024 •
edited
Loading

Description of changes

part of #121293

untested

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 9, 2024
@Stunkymonkey Stunkymonkey mentioned this pull request Apr 9, 2024
Open
42 tasks
@Stunkymonkey Stunkymonkey marked this pull request as ready for review April 9, 2024 19:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 9, 2024
@Stunkymonkey Stunkymonkey requested a review from nbraud June 17, 2024 22:45
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 20, 2024
@Stunkymonkey Stunkymonkey merged commit e1f8977 into NixOS:master Jun 24, 2024
26 checks passed
@Stunkymonkey Stunkymonkey deleted the vagrant-guest-install-chmod branch June 24, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@nbraud nbraud Awaiting requested review from nbraud

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @Aleksanaa @wegank