Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubyfmt: Use system jemalloc #304087

Merged
merged 1 commit into from
May 28, 2024
Merged

rubyfmt: Use system jemalloc #304087

merged 1 commit into from
May 28, 2024

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Apr 14, 2024

Description of changes

jemalloc-sys hardcodes the build system's pagesize (#202863), making it incompatible with systems that don't have the standard 4k page size (such as Asahi Linux).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

jemalloc-sys hardcodes the build system's pagesize (NixOS#202863), making it
incompatible with systems that don't have the standard 4k page size
(such as Asahi Linux).
@ofborg ofborg bot requested a review from bobvanderlinden April 14, 2024 18:47
@alyssais alyssais requested a review from yu-re-ka April 17, 2024 09:19
@yu-re-ka yu-re-ka merged commit 8f2d1bf into NixOS:master May 28, 2024
28 checks passed
florian-sanders-cc pushed a commit to florian-sanders-cc/nixpkgs that referenced this pull request Jun 6, 2024
jemalloc-sys hardcodes the build system's pagesize (NixOS#202863), making it
incompatible with systems that don't have the standard 4k page size
(such as Asahi Linux).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants