Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adafruit-nrfutil: remove nose and modernize #327199

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 14, 2024

Description of changes

Removes nose and just uses pytest's compatibility layer for tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re on fire! Thanks for taking the initiative with these.

@emilazy
Copy link
Member

emilazy commented Jul 14, 2024

Uhh, by the way, this should apparently be lib.licenses.unfree

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 14, 2024

sigh good ol' licensing issues. I'll update it.

@emilazy
Copy link
Member

emilazy commented Jul 14, 2024

I misspoke slightly, it’s at least lib.licenses.unfreeRedistributable. Sort of limits the utility of having this packaged, but hopefully upstream can resolve it.

@pyrox0 pyrox0 force-pushed the denose/adafruit-nrfutil branch from 7d29984 to 14372a7 Compare July 14, 2024 21:30
@pbsbot
Copy link

pbsbot commented Jul 19, 2024

Result of nixpkgs-review pr 327199 run on x86_64-linux 1

2 packages built:
  • adafruit-nrfutil
  • adafruit-nrfutil.dist

@pbsds pbsds merged commit 88add63 into NixOS:master Jul 19, 2024
31 checks passed
@pyrox0 pyrox0 deleted the denose/adafruit-nrfutil branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants