Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-es: fix missing node_modules directories #339841

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

felschr
Copy link
Member

@felschr felschr commented Sep 5, 2024

Description of changes

Fixes runtime error where some dependencies cannot be found in node_modules due to broken symlinks: #243432 (comment)

It's possible to fix this in npm-install-hooks itself: #333759.
However I haven't gotten a response yet, so I created this workaround to get the package fixed without any risk of breaking other packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This workaround won't be needed anymore once NixOS#333759 is merged, which
fixes the node_modules copying behavior in npm-install-hooks.
@ofborg ofborg bot requested a review from jtszalay September 5, 2024 17:11
@felschr felschr merged commit 7fa0c16 into NixOS:master Sep 9, 2024
33 of 34 checks passed
@felschr felschr deleted the protoc-gen-es-fix branch September 9, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant