-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc/immich: init #344300
base: master
Are you sure you want to change the base?
nixos/doc/immich: init #344300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM over all. I have a few nits, besides that. Thank you for the informative docs! I'm going to personally follow this guide now haha.
619fc4f
to
facf01c
Compare
facf01c
to
7220cb6
Compare
7220cb6
to
2f41434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some punctuation nitpicks
@getchoo if you have this many tiny adjustments to recommend, it's usually easier for everyone involved to just PR them against the PR branch. |
Signed-off-by: Sefa Eyeoglu <[email protected]>
af33b50
to
e7fae70
Compare
hi, I followed this guide and got stuck with some permission problems. inside my container based setup, the database user and owner of the tables was if you come across this issue, you can run this command on your db dump: after that, it worked like a charm and all my images, users, faces etc popped up with no issues :) thanks for writing up this guide!! |
I think I ran into that when I did my manual migration before this guide's existence too. The guide should probably cover that. |
Hi, i followed this guide, and i ran into an issue with the database, it says that the migrations relations already exists:
|
@mhdask please share some info such as which version you're migrating from. Also please just try again (wipe and everything), perhaps you just accidentally did something differently. |
I am migrating from 1.115.0 to 1.116.2 If i do a |
Could you update to 1.116.2 beforehand and then migrate to the module? |
I don't see the point of including human readable instructions for migrations that can also be automated (that's what computers are for). What happens when these instructions are out of date? Are you going to add a test to make sure it continues to work? If not, why should thousands of people be taking the time to even read this potentially out of date document in a year or two, after you have moved on to greener pastures ? I have no doubt these instructions might be useful today and it might be useful to include it today, but I don't see long term value in this contribution. Write something on the wiki until you can automate it. At that point, potentially document it and find people that want to maintain it. Once that is done, lasting value can happen. Such a script should probably be written as a collaboration of contributors of multiple larger distributions. |
That's a bit too high of a standard IMHO but feel free to create that perfect script you describe that magically knows to handle all the weird little differences between people's deployments and is up to date into all eternity. |
@mhdask I'm sorry to report that I also had this issue. I ended up just deleting the database and redoing everything. I worked for hours to try and fix it, but unfortunately never got anywhere. |
This is odd. TypeORM seems to check if the table exists before actually trying to create it. https://github.com/typeorm/typeorm/blob/e7649d2746f907ff36b1efb600402dedd5f5a499/src/migration/MigrationExecutor.ts#L496 Could this be an issue with the search path? |
@Atemu I just tried this, I upgraded the docker version first, and then made a fresh dump from that, but still have the same issue.
While I dont know how many photos you have, I would really prefer not having to do this, as I have around 35k photos, 5k vidoes, which have been index, thumbnailed, machine learned, etc.. 😆
@Scrumplex Is this something i can check? |
There's no need to bring out the pitchforks. Apparently, we are just in disagreement. Ultimately, all you need to do is convince someone with commit rights to merge it. I explained how I would like it to work, if at all. That's all. I don't know whether there's any RFC that defines such things, but the longer it exists, the more sensitive maintainers have become for the long term viability of changes, I think. This is not an invitation to further discuss, since your position is already clear. |
It would be interesting to see if there are any unexpected differwnces between the original database dump from the container and your current state. Perhaps you could try to dump your current NixOS database and diff the two files. Obviously the media paths are going to be different, but perhaps something else is wrong too? |
hahahah, very good point. My library is only a few thousand photos and I haven't done much with it yet. |
Im not sure which two dumps you want to compare, the one from the original (docker) database dump, and the new nixos service version? UPDATE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the guide. Commented on two points which caused issues. I think we need someone to run this beginning-to-end one more time.
Signed-off-by: Sefa Eyeoglu <[email protected]>
e7fae70
to
2d4b7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both points seem fixed, thank you.
I’ve already done things in my new module-based install, so it’s not easy to do a run-through the new version as-is...
I've also had to re-create my external libraries, due to path mismatches with the container. Only noticed this now. Not sure what should have been done at db dump level. This is really unfortunate, though — a lot of photos there… |
Shouldn't you only have to adjust the import paths of the existing libraries? You can do that in the UI without touching the db. |
Didn’t work for me. |
Should we merge this as-is? I think we could also move this into the NixOS wiki alternatively and allow people to refine it there. |
I don't think that would be too bad of an idea. This is a pretty big section in the manual for something that's fairly specific |
I feel like it's worth having in the official channel-specific "proper" documentation rather than the wiki. I've been meaning to have another look, try it and then merge but I've been putting off migrating my Immich setup... |
I just completed my migration and I would like to share my experience following this guide.
sed -E "s#upload/([^\t]+)/#$TARGET_LOCATION/\1/#g" ./immich-fixed-search-path.sql > ./immich-final.sql
|
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.