Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyopengl-accelerate: fix build with numpy 2 and gcc 14 #369043

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Dec 29, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@linsui linsui changed the title python3Packages.pyopengl-accelerate: use numpy_1 and fix build with g… python3Packages.pyopengl-accelerate: fix build with numpy 2 and gcc 14 Dec 29, 2024
@linsui linsui requested review from tjni and alyaeanyx December 31, 2024 08:18
@alyaeanyx
Copy link
Member

Friture seems to work fine again with this PR

@tjni
Copy link
Contributor

tjni commented Jan 2, 2025

After reading up on npy_intp, the change looks appropriate. Later today, I want to look over what the warnings are about.

Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. There's work upstream to fix the warnings in mcfletch/pyopengl#112 and mcfletch/pyopengl@44a580a, so soon we might be able to remove the error suppressions.

@tjni tjni merged commit bb950a2 into NixOS:master Jan 3, 2025
53 checks passed
@linsui linsui deleted the pyopengl branch January 3, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants