New version of Xpra from the fork #5

aszlig · 2012-06-05T13:38:21Z

This is because the original version is no longer in development, as stated on
the website at http://code.google.com/p/partiwm/wiki/xpra:

"This project is in deep hibernation; I haven't had time to devote for several
years now. If you are looking for xpra, you may prefer Antoine Martin's fork,
which receives more support. It is available at: http://xpra.org/"

So I guess its safe to switch over to that fork.

edolstra · 2012-06-21T03:35:57Z

pkgs/development/interpreters/cython/default.nix

+
+  buildPhase = "python setup.py build --build-base $out";
+
+  installPhase = "python setup.py install --prefix=$out";


This package should probably be moved into the pythonPackages set and use the buildPythonPackage function. Other than that it looks good to me.

I did this because it's actually not really a python package itself but an alternative to the python interpreter, such as pyrex (it is actually a fork of that). It generates C code (and after that a .so) out of a python file with special syntax/annotations, such as C type annotations/defines.

@edolstra Does @aszlig still need to move to pythonPackages and use buildPythonPackage, or is this good enough to merge?

@aszlig Your reasoning makes sense to me for why this isn't in pythonPackages, but wouldn't buildPythonPackage still help here?

This is because the original version is no longer in development, as stated on the website at http://code.google.com/p/partiwm/wiki/xpra: "This project is in deep hibernation; I haven't had time to devote for several years now. If you are looking for xpra, you may prefer Antoine Martin's fork, which receives more support. It is available at: http://xpra.org/" So I guess its safe to switch over to that fork.

Cython is not required in order to run XPRA, so we now explicitly specify what should be put into PYTHONPATH instead of using the PYTHONPATH which is set during build time. That way we don't get unnecessary stuff in /nix/store, like the mentioned cython compiler/interpreter.

This is not needed to run XPRA, but gets rid of a few nasty errors. XPRA is using the notify library to display nice desktop notifications, so there might be users who actually like to have those funny things.

aszlig · 2012-07-06T01:43:52Z

Okay, rebased the branch and added a fix to avoid that unnecessary paths (like those of cython) get added to PYTHONPATH.

New version of Xpra from the fork

Merge upstream master

# This is the 1st commit message: set CrossCompiling when cross compiling # The commit message #2 will be skipped: # jk, be conservative though ;) # The commit message #3 will be skipped: # 'quick' not perf-cross? # The commit message NixOS#4 will be skipped: # cross: no terminfo # The commit message NixOS#5 will be skipped: # ghc822: quick-cross

Maybe same problem as on Darwin, unsure. From gdb: > Thread 1 (process 23820): > #0 0x00007ffff7dab684 in __syscall_cp_c () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #1 0x00007ffff7daac69 in __timedwait_cp () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #2 0x00007ffff7daad17 in __timedwait () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #3 0x00007ffff7dacaf4 in pthread_mutex_timedlock () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > NixOS#4 0x00007ffff781e409 in _gpgrt_lock_lock () from target:/nix/store/f7qid95jabfr665qc1kbcl6adf48gq7w-libgpg-error-1.28/lib/libgpg-error.so.0 > NixOS#5 0x00007ffff7b035d5 in lock_rng () at ./rndjent.c:212 > NixOS#6 0x00007ffff7b036ab in _gcry_rndjent_poll (add=0x0, origin=RANDOM_ORIGIN_INIT, length=0) at ./rndjent.c:268 > NixOS#7 0x00007ffff7b038cf in _gcry_rndjent_get_version (r_active=0x7fffffffc800) at ./rndjent.c:339 > NixOS#8 0x00007ffff7a44f7f in print_config (fp=0x6026e0, what=0x0) at global.c:391 > NixOS#9 _gcry_get_config (mode=mode@entry=0, what=<optimized out>, what@entry=0x0) at global.c:420 > NixOS#10 0x00007ffff7a456a3 in _gcry_vcontrol (cmd=<optimized out>, arg_ptr=<optimized out>) at global.c:652 > NixOS#11 0x00007ffff7a41689 in gcry_control (cmd=cmd@entry=GCRYCTL_PRINT_CONFIG) at visibility.c:79 > NixOS#12 0x0000000000400ec3 in main (argc=<optimized out>, argv=<optimized out>) at version.c:160

concourse: Support boolean flags

buildRustCrate: support rlib dependency type

Update to last nixpkgs.

Fix jumping

Pull in _FORTIFY_SOURCE=3 stack smashing fix. Without the change on current `master` `rtorrent` crashes at start as: *** buffer overflow detected ***: terminated __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 44 pthread_kill.c: No such file or directory. (gdb) bt #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 NixOS#1 0x00007ffff7880af3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78 NixOS#2 0x00007ffff7831c86 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 NixOS#3 0x00007ffff781b8ba in __GI_abort () at abort.c:79 NixOS#4 0x00007ffff781c5f5 in __libc_message (fmt=fmt@entry=0x7ffff7992540 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150 NixOS#5 0x00007ffff7910679 in __GI___fortify_fail (msg=msg@entry=0x7ffff79924e6 "buffer overflow detected") at fortify_fail.c:24 NixOS#6 0x00007ffff790eea4 in __GI___chk_fail () at chk_fail.c:28 NixOS#7 0x00007ffff790ea85 in ___snprintf_chk (s=<optimized out>, maxlen=<optimized out>, flag=<optimized out>, slen=<optimized out>, format=<optimized out>) at snprintf_chk.c:29 NixOS#8 0x0000000000472acf in utils::Lockfile::try_lock() () NixOS#9 0x000000000044b524 in core::DownloadStore::enable(bool) () NixOS#10 0x00000000004b1f7b in Control::initialize() () NixOS#11 0x000000000043000b in main ()

Format using the base commit from nixfmt PR 6: piegamesde/nixfmt@ddef74c

Since ba83271 the build fails with applying patch /nix/store/46rxbbvl2l3mrxb50y9rzy7ahgx0lraj-d741901dddd731895346636c0d3556c6fa51fbe6.patch patching file tests/hazmat/primitives/test_aead.py Hunk #1 FAILED at 56. Hunk #2 FAILED at 197. Hunk NixOS#3 FAILED at 378. Hunk NixOS#4 FAILED at 525. Hunk NixOS#5 FAILED at 700. Hunk NixOS#6 FAILED at 844. 6 out of 6 hunks FAILED -- saving rejects to file tests/hazmat/primitives/test_aead.py.rej

Without the change `unnethack` startup crashes as: (gdb) bt #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 NixOS#1 0x00007f734250c0e3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78 NixOS#2 0x00007f73424bce06 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 NixOS#3 0x00007f73424a58f5 in __GI_abort () at abort.c:79 NixOS#4 0x00007f73424a67a1 in __libc_message (fmt=fmt@entry=0x7f734261e2f8 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150 NixOS#5 0x00007f734259b1d9 in __GI___fortify_fail (msg=msg@entry=0x7f734261e2df "buffer overflow detected") at fortify_fail.c:24 NixOS#6 0x00007f734259ab94 in __GI___chk_fail () at chk_fail.c:28 NixOS#7 0x00000000005b2ac5 in strcpy (__src=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", __dest=0x7ffe68838990 "\001") at /nix/store/B0S2LKF593R3585038WS4JD3LYLF2WDX-glibc-2.38-44-dev/include/bits/string_fortified.h:79 NixOS#8 curses_break_str (str=str@entry=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", width=width@entry=163, line_num=line_num@entry=1) at ../win/curses/cursmisc.c:275 NixOS#9 0x00000000005b3f51 in curses_character_input_dialog (prompt=prompt@entry=0x7ffe68838cf0 "Shall I pick a character's race, role, gender and alignment for you?", choices=choices@entry=0x7ffe68838d70 "YNTQ", def=def@entry=121) at ../win/curses/cursdial.c:211 NixOS#10 0x00000000005b9ca0 in curses_choose_character () at ../win/curses/cursinit.c:556 NixOS#11 0x0000000000404eb1 in main (argc=<optimized out>, argv=<optimized out>) at ./../sys/unix/unixmain.c:309 which corresponds to `gcc` warning: ../win/curses/cursmisc.c: In function 'curses_break_str': ../win/curses/cursmisc.c:275:5: warning: '__builtin___strcpy_chk' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=] 275 | strcpy(substr, str); | ^ I did not find a single small upstream change that fixes it. Let's disable `fortify3` until next release. Closes: NixOS#292113

kexec build process was broken in ff3c8c3

Strongly inspired by the forgejo counterpart[1], for the following reasons: * The feature is broken with the current module and crashes on authentication with the following stacktrace (with a PAM service `gitea` added): server # Stack trace of thread 1008: server # #0 0x00007f3116917dfb __nptl_setxid (libc.so.6 + 0x8ddfb) server # #1 0x00007f3116980ae6 setuid (libc.so.6 + 0xf6ae6) server # #2 0x00007f30cc80f420 _unix_run_helper_binary (pam_unix.so + 0x5420) server # #3 0x00007f30cc8108c9 _unix_verify_password (pam_unix.so + 0x68c9) server # #4 0x00007f30cc80e1b5 pam_sm_authenticate (pam_unix.so + 0x41b5) server # #5 0x00007f3116a84e5b _pam_dispatch (libpam.so.0 + 0x3e5b) server # #6 0x00007f3116a846a3 pam_authenticate (libpam.so.0 + 0x36a3) server # #7 0x00000000029b1e7a n/a (.gitea-wrapped + 0x25b1e7a) server # #8 0x000000000047c7e4 n/a (.gitea-wrapped + 0x7c7e4) server # ELF object binary architecture: AMD x86-64 server # server # [ 42.420827] gitea[897]: pam_unix(gitea:auth): unix_chkpwd abnormal exit: 159 server # [ 42.423142] gitea[897]: pam_unix(gitea:auth): authentication failure; logname= uid=998 euid=998 tty= ruser= rhost= user=snenskek It only worked after turning off multiple sandbox settings and adding `shadow` as supplementary group to `gitea.service`. I'm not willing to maintain additional multiple sandbox settings for different features, especially given that it was probably not used for quite a long time: * There was no PR or bugreport about sandboxing issues related to PAM. * Ever since the module exists, it used the user `gitea`, i.e. it had never read-access to `/etc/shadow`. * Upstream has it disabled by default[2]. If somebody really needs it, it can still be brought back by an overlay updating `tags` accordingly and modifying the systemd service config. [1] 07641a9 [2] https://docs.gitea.com/usage/authentication#pam-pluggable-authentication-module

@seanrmurphy

Co-authored-by: @seanrmurphy

@seanrmurphy

Co-authored-by: @seanrmurphy

edolstra reviewed Jun 21, 2012
View reviewed changes

aszlig added 4 commits July 6, 2012 03:12

Add Cython, because it's needed to build xpra.

af9924b

xpra: Add python notify module.

ceff799

This is not needed to run XPRA, but gets rid of a few nasty errors. XPRA is using the notify library to display nice desktop notifications, so there might be users who actually like to have those funny things.

peti added a commit that referenced this pull request Jul 16, 2012

Merge pull request #5 from aszlig/xpra

36265e9

New version of Xpra from the fork

peti merged commit 36265e9 into NixOS:master Jul 16, 2012

cstrahan pushed a commit to cstrahan/nixpkgs that referenced this pull request Dec 12, 2014

Merge pull request NixOS#5 from basvandijk/update

85a4f28

Merge upstream master

nbp added a commit that referenced this pull request Jan 18, 2015

Merge pull request #5 from ametaireau/syncserver

62e48b4

yokto mentioned this pull request Mar 7, 2016

Psi crashes upon account creation #13747

Closed

mz-pdm mentioned this pull request Nov 18, 2016

Emacs and X server crashes after upgrade to 16.09 #20535

Closed

grahamc mentioned this pull request Aug 13, 2017

Port Nix Pills in to a document produced by Nixpkgs #27908

Closed

19 tasks

TerkiKerel mentioned this pull request Jan 5, 2018

Opera does not starts #33479

Closed

oxij mentioned this pull request Mar 27, 2018

manual fails to build on master #37903

Closed

timokau mentioned this pull request Apr 9, 2018

tachyon: Add support for jpeg, png, more platforms #38119

Merged

8 tasks

dtzWill mentioned this pull request Jun 17, 2018

libgcrypt: disable tests w/musl, seems to hang #42146

Closed

8 tasks

dingxiangfei2009 pushed a commit to dingxiangfei2009/nixpkgs that referenced this pull request Jan 9, 2019

Merge pull request NixOS#5 from tenx-tech/boolean-flags

fec8a38

concourse: Support boolean flags

nagisa pushed a commit to nagisa/nixpkgs that referenced this pull request Jan 24, 2020

Merge pull request NixOS#5 from standard-ai/buildRustCrate-rlib-support

a3242ca

buildRustCrate: support rlib dependency type

Ma27 pushed a commit that referenced this pull request Feb 1, 2020

Merge pull request #5 from NixOS/master

e1902ba

Update to last nixpkgs.

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020

Merge pull request NixOS#5 from NixOS/master

708a37b

Update to last nixpkgs.

Valodim mentioned this pull request Feb 28, 2020

flutter: init 1.12.13+hotfix.8 #76420

Merged

10 tasks

tex mentioned this pull request Mar 22, 2020

FreeCAD crash on stratup in nixos-19.09 #83127

Closed

rochdiboudjehem mentioned this pull request Jun 6, 2020

mendeley 1.19.1 crash #43461

Closed

fgaz mentioned this pull request Jan 26, 2023

Packaging request: Our Paint #208940

Open

Zahrun mentioned this pull request Mar 28, 2023

kdenlive: cannot render "selected zone" #223654

Closed

MarceloEmmerich mentioned this pull request May 4, 2023

Build failure: xwayland 23.1.1 #229841

Closed

Patryk27 mentioned this pull request May 17, 2023

pcloud crashes with SIGSEGV on recent nixpkgs unstable #226339

Open

nat-418 added a commit to nat-418/nixpkgs that referenced this pull request Jul 8, 2023

Merge pull request NixOS#5 from nat-418/fix-line-jumping

a2ec529

Fix jumping

trofi mentioned this pull request Aug 4, 2023

rtorrent: 0.9.8+date=2021-08-07 -> 0.9.8+date=2022-06-20 #247086

Merged

12 tasks

infinisil pushed a commit to infinisil/nixpkgs that referenced this pull request Nov 16, 2023

base: Make PRs against the RFC branch do automatic renders (NixOS#5)

5249db3

Format using the base commit from nixfmt PR 6: piegamesde/nixfmt@ddef74c

ben0x539 mentioned this pull request Dec 5, 2023

tint2: 17.0.2 -> 17.1.3, switch to fork, fix compatibility with glib >= 2.76 #244547

Merged

12 tasks

MarkRijckenberg mentioned this pull request Mar 24, 2024

steamwebhelper crashloops due to reading /run/current-system/sw/lib/libbeidpkcs11.so from ~/.pki/nssdb/pkcs11.txt on NixOS 24.05.20240323.44d0940 (Uakari) x86_64 #298662

Closed

KiaraGrouwstra mentioned this pull request Apr 25, 2024

error 'Timed out waiting for device' on boot using boot.initrd.systemd.enable = true #306645

Closed

j-openmesh referenced this pull request in Openmesh-Network/Xnodepkgs Jul 7, 2024

Merge pull request #5 from Openmesh-Network/fix/broken-kexec-build

0ce57c3

kexec build process was broken in ff3c8c3

eclairevoyant mentioned this pull request Jul 26, 2024

ffmpeg-headless: enable additional encoders #330056

Merged

13 tasks

dezren39 added a commit to developing-today-forks/nixpkgs that referenced this pull request Oct 14, 2024

auto-patch and build workerd (NixOS#5)

bbe904a

Co-authored-by: @seanrmurphy

dezren39 added a commit to developing-today-forks/nixpkgs that referenced this pull request Oct 14, 2024

auto-patch and build workerd (NixOS#5)

da1973c

Co-authored-by: @seanrmurphy

Titaniumtown mentioned this pull request Oct 15, 2024

Build failure: python312Packages.onnx #348847

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New version of Xpra from the fork #5

New version of Xpra from the fork #5

aszlig commented Jun 5, 2012

edolstra Jun 21, 2012

aszlig Jun 21, 2012

shlevy Jul 2, 2012

shlevy Jul 8, 2012

aszlig commented Jul 6, 2012


		buildPhase = "python setup.py build --build-base $out";

		installPhase = "python setup.py install --prefix=$out";

New version of Xpra from the fork #5

New version of Xpra from the fork #5

Conversation

aszlig commented Jun 5, 2012

edolstra Jun 21, 2012

Choose a reason for hiding this comment

aszlig Jun 21, 2012

Choose a reason for hiding this comment

shlevy Jul 2, 2012

Choose a reason for hiding this comment

shlevy Jul 8, 2012

Choose a reason for hiding this comment

aszlig commented Jul 6, 2012