-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / UseURL: open file in workspace #5
Feature / UseURL: open file in workspace #5
Conversation
Hi! Thank you for the PR. I tried to make some modifications before merging, but fucked something up, so I merged anyway. Do you mind opening another PR with some adjustments? |
Thanks NomarCub! Great feedback, thanks - I'll send through another PR hopefully this weekend 👍 |
How about this weekend? 😄 |
@ptim will you take a look at this? |
Hi @ptim? I'd like to make a new release, and without the fixes I'd rather not include this and revert the changes. Will you be able to come through with a new PR soon? |
Thanks for the plugin!
code
on MacOS Plugin doesn't open my vault in VS Code #3child_process.exec
)Additionally, I added a prettier config that matched the original as closely as I could (it wasn't consistent) bc I was fighting the editor. Wasn't clear on how you were building, as I see that your dist is generated by rollup, whereas what's in this repo compiles with esbuild... works a treat, regardless!
HTH, ptim