Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add await in provider creation #5664

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add await in provider creation #5664

merged 2 commits into from
Aug 21, 2024

Conversation

fvictorio
Copy link
Member

In #5478 I added some debug logs to investigate a false negative we have now and then on EDR's CI. But I forgot to await the provider creation, so these logs are pretty useless as they are.

This PR just adds the proper await.

@fvictorio fvictorio requested a review from a team August 21, 2024 17:04
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 5:10pm

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 409e99f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 21, 2024
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fvictorio fvictorio merged commit ecb3665 into main Aug 21, 2024
105 checks passed
@fvictorio fvictorio deleted the await-edr-provider-creation branch August 21, 2024 20:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants