Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate if we need async NAPI APIs #816

Closed
OmarTawfik opened this issue Feb 15, 2024 · 0 comments · Fixed by #1120
Closed

investigate if we need async NAPI APIs #816

OmarTawfik opened this issue Feb 15, 2024 · 0 comments · Fixed by #1120
Assignees
@OmarTawfik

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Feb 15, 2024 •
edited
Loading

The Language.parse() API (and possibly others) should be turned async returning a Promise<T>. This is important for clients like an LSP that shouldn't block the main event loop over parsing that can happen in the background.

More info:
@OmarTawfik OmarTawfik converted this from a draft issue Feb 15, 2024
@OmarTawfik OmarTawfik changed the title enable async NAPI APIs investigate if we need async NAPI APIs Feb 20, 2024
@AntonyBlakey AntonyBlakey moved this from ⏳ Todo to 🔄 In Progress in Slang - 2024 H1 Apr 2, 2024
@OmarTawfik OmarTawfik assigned OmarTawfik and unassigned AntonyBlakey Oct 8, 2024
@OmarTawfik OmarTawfik mentioned this issue Oct 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@OmarTawfik
migrate NAPI front-end to WASM and ESM (#1120)
25eef3e 
See the added changesets for the specific API changes/additions.

Additionally, this PR:

- deprecates/removes NAPI build/pipeline.
- adds `jco` as a sub-module to the repo.
- deletes the platform-specific packages, as we now just need one.

Closes #410
Closes #570
Closes #573
Closes #816
Closes #987
@github-project-automation github-project-automation bot moved this from Todo to Done in Slang - Backlog Oct 8, 2024
@OmarTawfik OmarTawfik moved this from ⏳ Todo to ✅ Done in Slang - 2024 H2 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
None yet
Projects
No open projects
Slang - 2024 H2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate NAPI front-end to WASM and ESM OmarTawfik-forks/slang
2 participants
@AntonyBlakey @OmarTawfik