Define built-ins contexts (for Yul built-in functions) and synthetically build the stack graph for the built-ins #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ggiraldez
force-pushed
the
built-in-contexts
branch
from
f5c37a6 to
aa7fd27
Compare
…ing `BuiltInContext` This version is very broken but it represents most of the initial changes to `definitions.rs`
… enable `jump`/`jumpi`
... and remove parsing and processing Solidity generated files with the built-in definitions.
ggiraldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several changes to how built-ins are defined and processed. We define different built-in contexts to separate built-in symbols available in Solidity and Yul. Also, the part of the stack graph that contains all definitions of built-ins is now built directly into the stack graph, without generating a Solidity file and the processing it as a system file. This allows much faster initialization of the Bindings Graph and most symbol mangling is no longer needed since we're not required to parse the built-ins file anymore.
In addition, all Yul built-ins are no longer defined in the grammar as special keywords and instead are treated as normal identifiers and bound to built-in definitions using the regular binding rules.
NB: I'm not totally happy with how the code to build the built-ins stack graph is being generated (with Rust), but I took a stab at using Jinja templates for it and the partial results were getting comparatively too complicated.