Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let ClusterConnectionPool handle skip_full_coverage_check #118

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Let ClusterConnectionPool handle skip_full_coverage_check #118

merged 1 commit into from
Jul 14, 2019

Conversation

amatai
Copy link
Contributor

@amatai amatai commented Jul 12, 2019 •
edited
Loading

Description

In StrictRedisCluster.from_url ClusterConnectionPool should handle skip_full_coverage_check otherwise this flag is being ignored

Fixes Issue #117

NoneGG
NoneGG reviewed Jul 13, 2019
View reviewed changes
aredis/client.py Outdated Show resolved Hide resolved
NoneGG
NoneGG reviewed Jul 13, 2019
View reviewed changes
aredis/client.py Outdated Show resolved Hide resolved
@NoneGG
Copy link
Owner

NoneGG commented Jul 13, 2019

@amatai Thanks for your pr, that's nice, could you make a little change to some part of it?

@amatai
Copy link
Contributor Author

amatai commented Jul 14, 2019

@NoneGG Sure. Let me make the change, you suggested.

@NoneGG NoneGG merged commit 9eabfb0 into NoneGG:master Jul 14, 2019
@NoneGG
Copy link
Owner

NoneGG commented Jul 14, 2019

@amatai Merged, thanks~

NoneGG added a commit that referenced this pull request Dec 7, 2019
@NoneGG
release 1.1.6
1912ae4 
changes:

    * Fixbug: parsing stream messgae with empty payload will cause error(#116)

    * Fixbug: Let ClusterConnectionPool handle skip_full_coverage_check (#118)

    * New: threading local issue in coroutine, use contextvars instead of threading local in case of the safety of thread local mechanism being broken by coroutine (#120)

    * New: support Python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoneGG NoneGG NoneGG left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amatai @NoneGG