Bugfix: Fixed crash when MainActivity was destroyed when selecting a file #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this also simplifies the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Don't keep Activities" is enabled in Developer Settings Android is killing all Activities when switchin to a new one. This is very useful when testing proper closing and restoration of state.
In mRFCDM app, when the user has selected a device and is navigating to a File Browser to select a file the system is killing
MainActivity. The app closing theMcuMgrTransportobject inonCleared()in the view model, which was also stopping theHandlerThread. On restoration, the app was crashing, as a closed thread doesn't have a looper anymore.The PR changes when the transport gets closed. Not it happens from the
MainActivityinonDestroy()whenisFinishing()is returning true, that is only when the user is moving back to the scanner.