This repository has been archived by the owner on Jan 10, 2022. It is now read-only.
Added an error message if a repeated USB address is seen #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodem
reviewed
Jun 27, 2018
| _onUsbDetach(usbDevice) { | ||
| debug(`Called _triggerReenumeration because of detached USB device VID/PID 0x${ | ||
| usbDevice.deviceDescriptor.idVendor.toString(16).padStart(4, '0')}/0x${ | ||
| usbDevice.deviceDescriptor.idProduct.toString(16).padStart(4, '0')}`); |
There was a problem hiding this comment.
Could consider using one of the hexpad4() or getDeviceId() functions from util/usb.js.
| usbDevice.deviceDescriptor.idVendor.toString(16).padStart(4, '0')}/0x${ | ||
| usbDevice.deviceDescriptor.idProduct.toString(16).padStart(4, '0')}`); | ||
|
|
||
| this._triggerReenumeration(usbDevice) |
There was a problem hiding this comment.
Missing semicolon here. Looks like a npm run lintfix is needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (more) proper attempt to work around the serial port timeouts and
Open (SetCommState): File not foundissues on win7 on a particular family of laptops.The error message should just bubble up to the
nrf-connect-corelog viewer.