Remove bInterfaceProtocol check when blacklisting ModemManager #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bInterfaceProtocol=="01" check does not match nRF USB CDC ACM devices. These devices are then not blacklisted, and ModemManager will start interfering. Removing this check, as looking for the NRF_CDC_ACM variable (set by 71-nrf.rules) is sufficient for identifying nRF USB CDC ACM devices.
bencefr
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bInterfaceProtocol=="01"check does not match nRF USB CDC ACM devices. These devices are then not blacklisted, and ModemManager will start interfering. Removing this check, as looking for theNRF_CDC_ACMvariable (set by 71-nrf.rules) is sufficient for identifying nRF USB CDC ACM devices.Tested on Ubuntu 16.04 and 18.04.