This repository has been archived by the owner on Jan 10, 2022. It is now read-only.
Write up-to-date comments about waitForDisconnect() #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencefr
reviewed
Jun 18, 2018
| // 64-bit win. Previous implementations ( < v0.2.5) had workarounds, | ||
| // but those workarounds created problems on a specific USB XHCI root hub | ||
| // on win7 64-bit. | ||
| // The current implementation **assumes** that the DFU target will reset |
There was a problem hiding this comment.
I am under the impression that the current implementation does not assume the reset, it does close() regardless, correct me if I'm wrong.
There was a problem hiding this comment.
Yeah, it does. If the DFU target doesn't reset itself, the function will still return a fulfilled promise. Maybe it's a matter of wording?
There was a problem hiding this comment.
Yes it is, since DFU is expected to reset in any case, we don't force reset it, and the serialport close is another layer. Maybe if the wording indicates that this function is called when we expect that the target is/has reset... then we close the corresponding serialport.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #33 (inadvertently) left some old comments which are no longer true (i.e. the
waitForDisconnect()function no longer times out after 5 sec). This just gets those comments up to date.