Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links open in startup dialog #449

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix links open in startup dialog #449

merged 2 commits into from
Dec 17, 2024

Conversation

KievDevel
Copy link
Contributor

No description provided.

@KievDevel KievDevel added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Dec 17, 2024
@github-actions GitHub Actions
Copy link

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

datenreisender
datenreisender approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@datenreisender datenreisender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fix is of course absolutely fine. You could also use the ExternalLink component from shared, like e.g. done in PPK.

@KievDevel KievDevel merged commit 38f414d into main Dec 17, 2024
3 checks passed
@KievDevel KievDevel deleted the fix-links-startup-dialog-open branch December 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenreisender datenreisender datenreisender approved these changes

Assignees
No one assigned
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KievDevel @datenreisender