Fix: Check if app is truly installed befare reading package.json (#978)

* Fix: Check if app is truly installed before reading package.json
NordicSemiconductor · Feb 12, 2024 · 644d342 · 644d342
1 parent 4bd9e2f
commit 644d342
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/Changelog.minor.md b/Changelog.minor.md
@@ -25,6 +25,10 @@ release the new version.
 -   #950, #952: Use the refactored telemetry code.
 -   #958 Update electron from 22.x to 28.x
 
+### Fixed
+
+-   #978 Do not convert legacy app if it has been uninstalled in the mean time
+
 ## 4.3.0
 
 ### Fixed

diff --git a/src/main/apps/legacyMetaFiles.ts b/src/main/apps/legacyMetaFiles.ts
@@ -166,18 +166,20 @@ const migrateLegacyMetaFiles = (source: Source) => {
             'package.json'
         );
 
-        const packageJsonResult = parsePackageJsonLegacyApp(
-            readFile(packageJsonFile)
-        );
-
-        const packageJson = packageJsonResult.success
-            ? packageJsonResult.data
-            : null;
-
-        writeAppInfo(
-            createNewAppInfo(appName, appsJson, updatesJson, packageJson),
-            source
-        );
+        if (fs.existsSync(packageJsonFile)) {
+            const packageJsonResult = parsePackageJsonLegacyApp(
+                readFile(packageJsonFile)
+            );
+
+            const packageJson = packageJsonResult.success
+                ? packageJsonResult.data
+                : null;
+
+            writeAppInfo(
+                createNewAppInfo(appName, appsJson, updatesJson, packageJson),
+                source
+            );
+        }
     });
 
     createWithDrawnAppFiles('pc-nrfconnect-gettingstarted', source);