Skip to content

Commit

Permalink
Add missing waitForVisible in integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mrodem committed Jul 13, 2017
1 parent a1100e2 commit 930079a
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/oneLocalApp-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ let electronApp;

function loadFirstApp() {
return electronApp.client.windowByIndex(0)
.waitForVisible('button[title="Launch app"]')
.click('button[title="Launch app"]')
.then(() => waitForWindowCount(electronApp, 2))
.then(() => electronApp.client.waitUntilWindowLoaded());
Expand All @@ -71,6 +72,7 @@ describe('one local app', () => {

it('should show Test App in the launcher app list', () => (
electronApp.client.windowByIndex(0)
.waitForVisible('h4')
.getText('h4')
.then(text => expect(text).toEqual('Test App'))
));
Expand Down
1 change: 1 addition & 0 deletions test/oneLocalAppUnsupportedEngine-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ describe('one local app with unsupported engine', () => {

it('should show warning dialog when clicking Launch', () => (
electronApp.client.windowByIndex(0)
.waitForVisible('button[title="Launch app"]')
.click('button[title="Launch app"]')
.waitForVisible('.modal-dialog')
));
Expand Down
1 change: 1 addition & 0 deletions test/oneLocalAppWithoutEngine-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ describe('one local app without engine definition', () => {

it('should show warning dialog when clicking Launch', () => (
electronApp.client.windowByIndex(0)
.waitForVisible('button[title="Launch app"]')
.click('button[title="Launch app"]')
.waitForVisible('.modal-dialog')
));
Expand Down
1 change: 1 addition & 0 deletions test/oneOfficialAppInstalled-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ let electronApp;

function loadFirstApp() {
return electronApp.client.windowByIndex(0)
.waitForVisible('button[title="Launch app"]')
.click('button[title="Launch app"]')
.then(() => waitForWindowCount(electronApp, 2))
.then(() => electronApp.client.waitUntilWindowLoaded());
Expand Down
1 change: 1 addition & 0 deletions test/oneOfficialAppNotInstalled-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ describe('one official app not installed', () => {

it('should show welcome message in the launcher app list', () => (
electronApp.client.windowByIndex(0)
.waitForVisible('h4')
.getText('h4')
.then(text => expect(text).toEqual('Welcome to nRF Connect'))
));
Expand Down
1 change: 1 addition & 0 deletions test/oneOfficialAppUpgradable-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ describe('one official app upgradable', () => {

it('should show Test App in the launcher app list', () => (
electronApp.client.windowByIndex(0)
.waitForVisible('h4')
.getText('h4')
.then(text => expect(text).toEqual('Test App'))
));
Expand Down

0 comments on commit 930079a

Please sign in to comment.