Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installer script: always trigger JLink install for this version #1029

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Update installer script: always trigger JLink install for this version #1029

merged 4 commits into from
Jul 9, 2024

Conversation

KievDevel
Copy link
Contributor

Notes:

  • no changelog entry as this change is temporary and there is already somewhat related entry "Installation of the J-Link legacy driver on Windows."
  • Might be an inconvenience for the users that have higher/different version of the JLink for any reason, but clients will be able to cancel installation after it pops up.

@KievDevel KievDevel added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

kylebonnici
kylebonnici approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@KievDevel KievDevel merged commit 9e4a5c7 into main Jul 9, 2024
6 checks passed
@KievDevel KievDevel deleted the install-jlink-always-for-current-jlink branch July 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boundlesscalm boundlesscalm boundlesscalm approved these changes

@kylebonnici kylebonnici kylebonnici approved these changes

Assignees
No one assigned
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KievDevel @kylebonnici @boundlesscalm