Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get J-Link from Artifactory #1063

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Get J-Link from Artifactory #1063

merged 4 commits into from
Dec 9, 2024

Conversation

datenreisender
Copy link
Contributor

@datenreisender datenreisender commented Dec 2, 2024

Only executed while building the launcher. J-Link is already uploaded to https://files.nordicsemi.com/ui/native/swtools/external/ncd/jlink/. The checksum files are not visible, but they can be fetched from the same location (e.g. https://files.nordicsemi.com/artifactory/swtools/external/ncd/jlink/JLink_Windows_V794i_x86_64.exe.sha256).

Part of NCD-1110.

@datenreisender datenreisender changed the title Get JLink from Artifactory Get J-Link from Artifactory Dec 2, 2024
@datenreisender datenreisender added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Dec 2, 2024
@NordicSemiconductor NordicSemiconductor deleted a comment from github-actions bot Dec 2, 2024
The JLink installers are alread uploaded to Artifactory, so we can get
them from there instead of the outdated developer.nordicsemi.com.
Because Artifactory provides MD5 and SHA256 checksums for all files, we
can easily switch to the more secure SHA256 checksums.

Also, splitting of the checksum is not needed anymore, because on
Artifactory that file only contains the checksum.
If Axios didn't find a file, it might also reject the promise.
Copy link
Contributor

@boundlesscalm boundlesscalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datenreisender datenreisender merged commit 47cd92b into main Dec 9, 2024
6 checks passed
@datenreisender datenreisender deleted the feat/artifactory/jlink branch December 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants