Bug/icon #120
Merged
Bug/icon #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fconnect-core * 'master' of https://github.com/NordicSemiconductor/pc-nrfconnect-core: (36 commits) update snapshot remove language nib files from template.app code review on mac code review on mac code review on windows change back from debug mode remove png-to-ico change the way of converting icon from png-to-ico to png2icons shortcut works on everywhere now pause testing shortcut for mac is workingggggggggg jest mock test jest mock test add testing for shortcut temporary solution for mac os change args to yargs drag to create shortcut clean once more remove a console fix ErrorDialogActions.showDialog in desktop shortcut ...
bencefr
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix on Windows.
Fix on MacOS.
Not fix on Linux