Compile fix #2
Merged
Compile fix #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bencefr
commented
Oct 20, 2017
bencefr
commented
- added missing copyright headers
- fixed linting issues
- fixed missing prop types
- fixed react errors
bihanssen
approved these changes
Oct 23, 2017
mrodem
reviewed
Oct 23, 2017
actions/jprog.js
Outdated
| @@ -69,7 +104,7 @@ export function logDeviceInfo(serialNumber, comName) { | |||
| // LOAD_TARGET_INFO action, listen to LOAD_TARGET_INFO_SUCCESS | |||
| // in middleware and log it from there? | |||
| dispatch({ | |||
| type: 'target-size-known', | |||
| type: 'TARGET-SIZE-KNOWN', | |||
There was a problem hiding this comment.
How about using underscores instead of dashes, i.e. TARGET_SIZE_KNOWN? This is the convention we have used for action type names in our other projects.
mrodem
approved these changes
Oct 23, 2017
IvanSanchez
suggested changes
Oct 23, 2017
actions/files.js
Outdated
| @@ -217,7 +255,7 @@ export function checkUpToDateFiles(fileLoadTimes, dispatch) { | |||
| const lastLoaded = (new Date(newestFileTimestamp)).toLocaleString(); | |||
|
|
|||
| electron.remote.dialog.showMessageBox({ | |||
| type: 'warning', | |||
| type: 'WARNING', | |||
There was a problem hiding this comment.
According to https://github.com/electron/electron/blob/master/docs/api/dialog.md#dialogshowmessageboxbrowserwindow-options-callback , this should be lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.