Print overhaul #373
Merged
Print overhaul #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
print
branch
4 times, most recently
from
802f0b9 to
528dd3e
Compare
FilipZajdel
requested changes
Dec 19, 2023
include/zcbor_print.h
Outdated
| #endif | ||
|
|
||
| #ifdef ZCBOR_VERBOSE | ||
| #define zcbor_trace() (zcbor_do_print("bytes left: %zu, byte: 0x%x, elem_count: 0x%zx, err: %d, %s:%d\n",\ |
There was a problem hiding this comment.
I think it should have a state param.
There was a problem hiding this comment.
Added two new commits where this (and more) is changed. The previous commits are unchanged.
| zcbor_do_print("%x ", str1[j] != str2[j]); | ||
| } | ||
| zcbor_do_print("\r\n"); | ||
| zcbor_do_print("\r\n"); |
There was a problem hiding this comment.
Does it intentionally print "\r\n" twice?
There was a problem hiding this comment.
Yes, to make it visually separate from the next thing to be printed.
From zcbor_debug.h (deleted) and zcbor_common.h Signed-off-by: Øyvind Rønningstad <[email protected]>
and zcbor_print_assert() to zcbor_log_assert() Signed-off-by: Øyvind Rønningstad <[email protected]>
Needs cleaning up of format strings. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
print
branch
from
ff612ee to
22a9c6a
Compare
Make printout more terse, and make the most printed instance (value_extract) not print the whole path. Pass state parameter to macro. Add more trace printing to zcbor_decode.c, and to errors. Signed-off-by: Øyvind Rønningstad <[email protected]>
Print from generated code, and include function name Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
print
branch
from
22a9c6a to
6eb5d5b
Compare
FilipZajdel
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.