Doc fix #383
Merged
Doc fix #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
requested review from
hakonfam,
sigvartmh,
busserull and
kyberdin
kyberdin
reviewed
Jan 18, 2024
ARCHITECTURE.md
Outdated
| @@ -117,20 +117,15 @@ This class relies heavily on decoding libraries for CBOR/YAML/JSON: | |||
|
|
|||
| All three use the same internal representation of the decoded data, so it's trivial to convert between them. | |||
| The representation for all three is 1-to-1 with the corresponding Python types, (list -> list, map -> dict, uint -> int, bstr -> bytes etc.). | |||
| The only proprietary Python class used is `CBORTag` for CBOR tags. | |||
| The only proprietary Python classes used is `cbor2.CBORTag` for CBOR tags, `cbor2.undefined` for CBOR `undefined` values, and `cbor2.CBORSimpleValue` for CBOR simple values (#7.0 -> #7.255 excluding bools, nil, and undefined). | |||
There was a problem hiding this comment.
Thanks, fixed
sigvartmh
reviewed
Jan 26, 2024
ARCHITECTURE.md
Outdated
| @@ -173,11 +168,12 @@ CodeRenderer | |||
| ------------ | |||
|
|
|||
| CodeRenderer is a standalone class that takes the result of the CodeGenerator class and constructs files. | |||
| There are 3 files constructed: | |||
| There are 4 files constructed: | |||
There was a problem hiding this comment.
Up to ? as if you don't opt into the optional cmake file?
There was a problem hiding this comment.
Thanks, added "up to"
Signed-off-by: Øyvind Rønningstad <[email protected]>
Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
doc-fix
branch
from
0b6a93c to
f8f859a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.