Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Hotfix 3.11.1 - Fix Add Multiple Products To Cart Javascript Function #529

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

supercid
Copy link
Member

Description

Fixes an error on the add multiple products to cart javascript function, where the SKU would be added instead of the parent configurable product with super attributes.

Related Issue

Fixes #528

Motivation and Context

In some setups, the added product can have no image or link to the product page.

How Has This Been Tested?

Run

Nosto.addMultipleProductsToCart([
        {'productId' : '425', 'skuId' : '310'},
		{'productId' : '425', 'skuId' : '314'},
		{'productId' : '425', 'skuId' : '312'},
		{'productId' : '425', 'skuId' : '313'},
    ], this);

And observe that the products are correctly added to cart with images and links to the product page.

Documentation:

N/A

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid added the bug label Jul 12, 2019
@supercid supercid added this to the 3.11.1 milestone Jul 12, 2019
@supercid supercid self-assigned this Jul 12, 2019
@supercid supercid merged commit 049f3b0 into master Jul 12, 2019
@supercid supercid deleted the hotfix/add-to-cart-js-function branch July 12, 2019 12:12
@supercid supercid mentioned this pull request Jul 23, 2019
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants