Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Hotfix 3.11.4 - Add category tagging to product tagging & Fix hidden categories #542

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

supercid
Copy link
Member

@supercid supercid commented Dec 4, 2019

Description

Fixes two issues:

  • Category tagging not being rendered on PDP.
  • Add the possibility to render category tagging for categories in which parents are hidden categories.

Related Issue

Closes #544
Closes #543

How Has This Been Tested?

  • Tested with Magento 1.9

Documentation:

N/A

Possible caveats

  • Now child categories are treated as root if the parent is hidden. Which is the same behavior as Magento breadcrumbs. (Which makes sense, since the parent is hidden and inactive)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid changed the title Add category tagging to product tagging Hotfix 3.11.4 - Add category tagging to product tagging & Fix hidden categories Dec 4, 2019
@supercid supercid self-assigned this Dec 4, 2019
@supercid supercid added the bug label Dec 4, 2019
@supercid supercid added this to the 3.11.4 milestone Dec 4, 2019
@supercid supercid marked this pull request as ready for review December 4, 2019 12:10
@supercid supercid merged commit ac5efa1 into master Dec 5, 2019
@supercid supercid deleted the hotfix/3.11.4 branch December 5, 2019 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants