Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add inventory level SKU #214

Merged
merged 5 commits into from
Jun 11, 2019
Merged

Feature/add inventory level SKU #214

merged 5 commits into from
Jun 11, 2019

Conversation

supercid
Copy link
Member

@supercid supercid commented Jun 10, 2019 •
edited
Loading

Description

Amend inventory level on SKU products as well.

Related Issue

Closes #174

Motivation and Context

We already had the field available on Playcart, but the extensions are not sending the SKU level. This makes it available for the extensions to send this extra field.

How Has This Been Tested?

Tested with Magento 1 extension. See this PR.

Documentation:

N/A

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid requested a review from fairlane June 10, 2019 10:16
@supercid supercid self-assigned this Jun 10, 2019
@supercid supercid requested review from olsi-qose and mridang June 10, 2019 10:34
@supercid supercid added this to the 3.15.0 milestone Jun 10, 2019
@supercid supercid merged commit d0c5c0b into develop Jun 11, 2019
@supercid supercid deleted the feature/add-inventory-level-sku branch June 11, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairlane fairlane fairlane approved these changes

@olsi-qose olsi-qose olsi-qose approved these changes

@mridang mridang Awaiting requested review from mridang

Assignees

@supercid supercid

Labels
enhancement
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Add inventory level class variable for SKU
3 participants
@supercid @fairlane @olsi-qose