Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xamarin.Mac.NET (xamarinmacnet) #562

Closed
wants to merge 3 commits into from
Closed

Conversation

joelverhagen
Copy link
Member

Address NuGet/Home#2662

  • Add xamarinmacnet TFM.
  • xamarinmacnet supports net45, xamarinmac, dotnet5.6, and netstandard1.6.
  • xamarinmacnet prefers xamarinmac over net45 when both are available.

@emgarten @rrelyea @yishaigalatzer @chamons @mteper @ericstj

@emgarten
Copy link
Member

emgarten commented May 4, 2016

:shipit:

@joelverhagen
Copy link
Member Author

joelverhagen commented May 11, 2016

Hey @ghuntley, before making this change, I'd like to understand the scenario a little more. I have some additional questions on the issue:
NuGet/Home#2662

@emgarten
Copy link
Member

emgarten commented Mar 2, 2017

🔔 Does this still need to go in or should it be closed?

@ghuntley
Copy link

ghuntley commented Mar 2, 2017

Still blocked by NuGet/Home#2662

@joelverhagen joelverhagen changed the title Add Xamarin.Mac.NET (xamarinmacnet45) Add Xamarin.Mac.NET (xamarinmacnet) Mar 2, 2017
@ghuntley
Copy link

ghuntley commented Mar 2, 2017

Paging @mhutch as per her comments at NuGet/Home#2662 (comment)

@emgarten
Copy link
Member

@joelverhagen any updates on this?

//cc @mishra14

@joelverhagen
Copy link
Member Author

@rrelyea is going to working with someone on client team to push this through. See NuGet/Home#2662 (comment).

@mishra14
Copy link
Contributor

Closing this PR as there has been no traction from the Xamarin folks. This can be reopened, if needed.

@nkolev92 nkolev92 deleted the jver-xamarintfm branch November 13, 2017 01:39
@chamons
Copy link

chamons commented Nov 13, 2017

@rrelyea @joelverhagen @mishra14 What work on the Xamarin side needs to be done? To our knowledge, it got handed off via:

@rrelyea is going to working with someone on client team to push this through. See NuGet/Home#2662 (comment).

@chamons
Copy link

chamons commented Nov 13, 2017

Please consider reopening, this is not fixed or forgotten.

@joelverhagen joelverhagen restored the jver-xamarintfm branch November 13, 2017 15:29
@emgarten
Copy link
Member

@chamons will you open a new PR and bring this up to date?

I'm still unclear on the hold up here, but the codebased has changed in 1.5 years and this change likely needs some work to sync it up.

@joelverhagen joelverhagen deleted the jver-xamarintfm branch January 19, 2018 15:36
@mrward
Copy link
Member

mrward commented Feb 2, 2018

I am planning to resurrect this fix and rebase it on the latest code, just not had chance to look at it yet.

@joelverhagen
Copy link
Member Author

Hey @mrward, is this visible to you?
https://github.com/NuGet/NuGet.Client/pull/562/files

@mrward
Copy link
Member

mrward commented Feb 2, 2018

@joelverhagen - Yeah I can see the files from the pull request. I saw the branch was deleted so I thought the changes were gone but they are still available 👍

@joelverhagen joelverhagen restored the jver-xamarintfm branch February 2, 2018 15:54
@joelverhagen
Copy link
Member Author

I've restored the branch -- hope it helps.

@nkolev92 nkolev92 deleted the jver-xamarintfm branch April 3, 2018 23:31
mattleibow added a commit to mattleibow/NuGet.Client that referenced this pull request Dec 18, 2018
 - `Xamarin.Mac.NET` is both `Xamarin.Mac,Version=v2.0` (preferred) AND `.NETFramework,Version=v4.5`
 - Related to
    - NuGet/Home#2662
    - NuGet#562
    - NuGet/NuGet2#47
@mattleibow
Copy link

Reopened this with #2572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants